On Wed, Oct 31, 2018 at 06:02:29PM +0100, Thomas Monjalon wrote: > 31/10/2018 03:17, Cody Doucette: > > Compilation flag D_XOPEN_SOURCE is causing failsafe to fail to > > build when changing some DPDK libraries. The flag is not needed > > and therefore is removed. > > > > Signed-off-by: Cody Doucette <douce...@bu.edu> > > Gaetan, please approve that the flag is not needed. >
I suspected popen or fgets from failsafe_args.c, but I wasn't able to find a reason for the define. I can't remember the initial reason for it, sorry. I have tested the build on linux and freebsd, without issue, so at this point I think this is ok. -- Gaëtan Rivet 6WIND
