Re: [dpdk-dev] [PATCH v7 4/5] hash: add lock-free read-write concurrency

[Jerin Jacob]

-----Original Message-----
> Date: Tue, 06 Nov 2018 10:13:53 +0100
> From: Thomas Monjalon <tho...@monjalon.net>
> To: Jerin Jacob <jerin.ja...@caviumnetworks.com>
> Cc: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>,
>  "bruce.richard...@intel.com" <bruce.richard...@intel.com>,
>  "pablo.de.lara.gua...@intel.com" <pablo.de.lara.gua...@intel.com>,
>  "dev@dpdk.org" <dev@dpdk.org>, "yipeng1.w...@intel.com"
>  <yipeng1.w...@intel.com>, Dharmik Thakkar <dharmik.thak...@arm.com>,
>  "Gavin Hu (Arm Technology China)" <gavin...@arm.com>, nd <n...@arm.com>,
>  "ferruh.yi...@intel.com" <ferruh.yi...@intel.com>,
>  "hemant.agra...@nxp.com" <hemant.agra...@nxp.com>,
>  "chao...@linux.vnet.ibm.com" <chao...@linux.vnet.ibm.com>, "Kapoor,
>  Prasun" <prasun.kap...@cavium.com>
> Subject: Re: [dpdk-dev] [PATCH v7 4/5] hash: add lock-free read-write
>  concurrency
> 
> 06/11/2018 10:10, Jerin Jacob:
> > From: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>
> > > Jerin, thank you for running this test and all the analysis. I have not 
> > > run this test. I was focused on simultaneous reads and writes. You can 
> > > look at file test_hash_readwrite_lf.c to look for the kind of the use 
> > > cases.
> > >
> > > I am trying to reproduce this, I will get back with more details soon.
> >
> > OK. Since RC2 approaching, bit worried about next steps if we cannot
> > avoid the regression with this new feature for this release.
> 
> 18.11-rc2 is already out.
> 
> > 24% drop of performance regression not seen in past for a specific
> > usecase.So not sure what we did past for similar situations.
> >
> > Thomas,
> > Any thought of this?
> 
> Everything is possible, you just need to agree on a patch.
> Please let's fix (or disable or revert) it in -rc3 this week.

I let Honnappa to decide fix, disable or revert action for rc3 release.
But it should either one of them for rc3 not this patch as is.

> 
>