Sunday, November 11, 2018 11:56 AM, Ophir Munk: > Subject: RE: [v2] app/testpmd: revert setting default RSS > > On 09.11.2018 12:38, Ophir Munk wrote: > > > This reverts the patch that enables default RSS action by setting > > > key=NULL and key_len=0. > > > In current testpmd implementation a key pointer must exist if > > > key_len!=0. For example, the following flow rule will cause a > > > segmentation fault: > > > flow create 0 <pattern> actions rss queues 0 1 end key_len 40 / end > > > > Maybe it's better to check that 'key_len' and 'key' passed both or none? > > I agree. However I don't see this option easily added to current testpmd flow > implementation. > Adrien - how would you recommend adding this check? > Please note that currently if no key and no key_len are specified - testpmd > still assign a dummy string.
AFAIU, this patch is to restore the previous behavior of testpmd. it might not be perfect, yet worked. The current mode is that testpmd is broken. So I suggest to take this patch as is, and have the optimization later/in other release.
