Re: [dpdk-dev] [PATCH v4 4/9] app/procinfo: add support for show port

[Pattan, Reshma]

> -----Original Message-----
> From: Varghese, Vipin
> Sent: Tuesday, November 6, 2018 12:49 PM
> To: dev@dpdk.org; tho...@monjalon.net; Pattan, Reshma
> <reshma.pat...@intel.com>; step...@networkplumber.org; Mcnamara, John
> <john.mcnam...@intel.com>
> Cc: Byrne, Stephen1 <stephen1.by...@intel.com>; Glynn, Michael J
> <michael.j.gl...@intel.com>; Patel, Amol <amol.pa...@intel.com>; Varghese,
> Vipin <vipin.vargh...@intel.com>
> Subject: [PATCH v4 4/9] app/procinfo: add support for show port


> +             snprintf(bdr_str, 100, " Port (%u)", i);

%s/100/MAX_STRING_LEN ?

> +                     ret = rte_eth_dev_rss_hash_conf_get(i, &rss_conf);
> +                     if ((ret) || (rss_conf.rss_key == NULL))
> +                             continue;
> +
> +                     printf("\t  -- RSS len %u key (hex):",
> +                             rss_conf.rss_key_len);
> +                     for (k = 0; k < rss_conf.rss_key_len; k++)
> +                             printf(" %x", rss_conf.rss_key[k]);
> +                     printf("\t  -- hf 0x%"PRIx64"\n",
> +                             rss_conf.rss_hf);
> +             }
> +

Should this be out of queues for loop? 

Thanks,
Reshma