Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

[Pattan, Reshma]

> -----Original Message-----
> From: Varghese, Vipin
> Sent: Thursday, November 22, 2018 1:28 PM
> To: Pattan, Reshma <reshma.pat...@intel.com>; dev@dpdk.org;
> tho...@monjalon.net; step...@networkplumber.org; Mcnamara, John
> <john.mcnam...@intel.com>
> Cc: Byrne, Stephen1 <stephen1.by...@intel.com>; Glynn, Michael J
> <michael.j.gl...@intel.com>; Patel, Amol <amol.pa...@intel.com>
> Subject: RE: [PATCH v4 5/9] app/procinfo: add support for show tm
> 
> Hi Reshma,
> 
> <snipped>
> 
> >
> > > +                 if ((ret) | (!is_leaf))
> > > +
> >
> > Is the operator here should be || ?
> >
> >
> 
> Check is done for 'if either ret is not 0 or if it ret is 0 but not leaf' we 
> skip leaf
> details print. If 'ret is 0 and is leaf' we skip continue to print leaf 
> details.

IMO, using logical operator over bitwise operator is good here in if statement  
. Like below.?

If (ret || (is_leaf == 0 ))