Hi Qi,
> -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, December 13, 2018 4:47 PM > To: Lu, Wenzhuo <[email protected]>; [email protected] > Cc: Lu, Wenzhuo <[email protected]>; Yang, Qiming > <[email protected]>; Li, Xiaoyun <[email protected]>; Wu, Jingjing > <[email protected]> > Subject: RE: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update > > Hi Wenzhuo: > > > -----Original Message----- > > From: dev [mailto:[email protected]] On Behalf Of Wenzhuo Lu > > Sent: Wednesday, December 12, 2018 3:00 PM > > To: [email protected] > > Cc: Lu, Wenzhuo <[email protected]>; Yang, Qiming > > <[email protected]>; Li, Xiaoyun <[email protected]>; Wu, > > Jingjing <[email protected]> > > Subject: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update > > > > Add ops link_update. > > > > +ice_interrupt_handler(void *param) > > +{ > > + struct rte_eth_dev *dev = (struct rte_eth_dev *)param; > > + struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > > + uint32_t oicr; > > I saw the patch also enabled interrupt handler, which looks like be > independent and not related with the commit log. > It's better to separate it. Here we only enable LSC interrupt for link update. So, I prefer putting it in this patch.
