Re: [dpdk-dev] [PATCH v3 34/34] net/ice: support meson build

[Lu, Wenzhuo]

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Friday, December 14, 2018 4:48 PM
> To: Lu, Wenzhuo <wenzhuo...@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 34/34] net/ice: support meson build
> 
> On 12/14/2018 2:38 AM, Lu, Wenzhuo wrote:
> <...>
> 
> >>> @@ -0,0 +1,30 @@
> >>> +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Intel
> >>> +Corporation
> >>> +
> >>> +sources = [
> >>> + 'ice_controlq.c',
> >>> + 'ice_common.c',
> >>> + 'ice_sched.c',
> >>> + 'ice_switch.c',
> >>> + 'ice_nvm.c',
> >>
> >> ice_dcb.c? It is in base folder, isn't is compiled?
> > Currently we don’t use it. Just leave it uncompiled.
> 
> Why not remove it now, and add back when used?
To touch the base code or not, it's a question. But anyway, it's a whole unused 
file, I can remove it.