On Mon, 2018-12-17 at 16:26 +0000, Wiles, Keith wrote: > > On Dec 16, 2018, at 4:22 PM, Luca Boccassi <bl...@debian.org> > > wrote: > > > > On Sun, 2018-12-16 at 11:46 -0600, Keith Wiles wrote: > > > --- /dev/null > > > +++ b/lib/librte_dfs/meson.build > > > @@ -0,0 +1,47 @@ > > > +# SPDX-License-Identifier: BSD-3-Clause > > > +# Copyright(c) 2018 Intel Corporation > > > + > > > +version = 1 > > > > You can leave the version out if it's 1, it's the default > > I understand that maybe the default, but it should not hurt anything > and then the developer can update it as needed, right?
Yes it does not hurt, I don't mind much either way, just wanted to mention there's a default in case you prefer to reduce duplication. > > > --- /dev/null > > > +++ b/lib/librte_dfs/Makefile > > > @@ -0,0 +1,51 @@ > > > +# SPDX-License-Identifier: BSD-3-Clause > > > +# Copyright(c) 2018 Intel Corporation > > > + > > > +include $(RTE_SDK)/mk/rte.vars.mk > > > + > > > +# library name > > > +LIB = librte_dfs.a > > > + > > > +CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) -O3 > > > +CFLAGS += -DALLOW_EXPERIMENTAL_API -D_FILE_OFFSET_BITS=64 > > > +CFLAGS += -D_GNU_SOURCE > > > +CFLAGS += -I$(RTE_SDK)/drivers/bus/pci > > > +LDLIBS += -lrte_eal -lrte_mempool -lrte_hash -lrte_ethdev > > > -lrte_utils > > > +LDLIBS += -lrte_ring -lrte_timer -lrte_rawdev -lrte_cryptodev > > > +LDLIBS += -lpthread > > > +LDLIBS += $(shell pkg-config --libs-only-l fuse3) > > > +LDLIBS += $(shell pkg-config --libs-only-l jansson) > > > > Why --libs-only-l ? If the libraries are not installed in the > > canonical > > path (eg: build-root-without-chroot) it will break as it won't use > > the > > -L > > OK, will look at this one and see if I had a reason to use libs-only- > l. > > > > > -- > > Kind regards, > > Luca Boccassi > > Regards, > Keith > -- Kind regards, Luca Boccassi
