Hi Fan,
> -----Original Message-----
> From: dev [mailto:[email protected]] On Behalf Of Fan Zhang
> Sent: Thursday, December 20, 2018 5:22 AM
> To: [email protected]
> Cc: [email protected]; De Lara Guarch, Pablo
> <[email protected]>; Nowak, DamianX
> <[email protected]>; Krakowiak, LukaszX <[email protected]>
> Subject: [dpdk-dev] [PATCH v4] crypto/aesni_mb: support plain SHA
>
> This patch adds the plain SHA1, SHA224, SHA256, SHA384, and SHA512
> algorithms support to AESNI-MB PMD. The cryptodev unit test and
> documentation are updated accordingly.
>
> This patch depends on "[v6] crypto/aesni_mb: support AES-GMAC"
> (http://patchwork.dpdk.org/patch/49180/)
>
> Signed-off-by: Damian Nowak <[email protected]>
> Signed-off-by: Lukasz Krakowiak <[email protected]>
> Signed-off-by: Fan Zhang <[email protected]>
> ---
//snip//
> @@ -428,7 +433,12 @@ static const struct blockcipher_test_case
> hash_test_cases[] = {
> .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
> BLOCKCIPHER_TEST_TARGET_PMD_CCP |
> BLOCKCIPHER_TEST_TARGET_PMD_MVSAM |
> +#if IMB_VERSION(0, 52, 0) > IMB_VERSION_NUM
> BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX
> +#else
> + BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX |
> + BLOCKCIPHER_TEST_TARGET_PMD_MB
> +#endif
[Fiona] Only a nit, but it's messy to include OCTEONTX in this.
MB doesn't have to be added after the other flags, it would be more readable and
easier for other PMD flags to be added in future if it was put on the previous
line, e.g.
> BLOCKCIPHER_TEST_TARGET_PMD_MVSAM |
> +#if IMB_VERSION_NUM >= IMB_VERSION(0, 52, 0)
> + BLOCKCIPHER_TEST_TARGET_PMD_MB |
> +#endif
> BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX
Apart from that
Acked-by: Fiona Trahe <[email protected]>
