13/01/2019 20:28, Wiles, Keith:
> > On Jan 13, 2019, at 9:38 AM, Nithin Kumar Dabilpuram
> > <ndabilpu...@marvell.com> wrote:
> > --- a/lib/librte_ethdev/rte_ethdev.c
> > +++ b/lib/librte_ethdev/rte_ethdev.c
> > + if (rc >= RTE_MEMZONE_NAMESIZE) {
> > + RTE_ETHDEV_LOG(ERR, "truncated name");
> > + rte_errno = ENAMETOOLONG;
> > + return NULL;
> > + }
>
> I we are already returning an error here should the RTE_LOG be DEBUG
> and not ERR.
> Of course this does mean we would have to check return codes :-)
In the general case, we should always log the errors as RTE_LOG_ERR,
no matter it is handled and logged again at an upper level.
Don't you think so?
