On 1/21/2019 10:43 AM, Parthasarathy, JananeeX M wrote: > > >> -----Original Message----- >> From: dev [mailto:[email protected]] On Behalf Of Chaitanya Babu Talluri >> Sent: Friday, January 18, 2019 8:54 PM >> To: [email protected] >> Cc: [email protected]; Pattan, Reshma <[email protected]>; >> [email protected]; Xing, Beilei <[email protected]>; Zhang, Qi Z >> <[email protected]>; [email protected]; De Lara Guarch, >> Pablo <[email protected]>; Doherty, Declan >> <[email protected]>; Chaitanya Babu, TalluriX >> <[email protected]>; [email protected] >> Subject: [dpdk-dev] [PATCH v2] drivers: fix to replace strcat with strncat >> >> Strcat does not check the destination length and there might be chances of >> string overflow so insted of strcat, strncat is used. >> >> Fixes: 540a211084 ("bnx2x: driver core") >> Fixes: e163c18a15 ("net/i40e: update ptype and pctype info") >> Fixes: ef28aa96e5 ("net/nfp: support multiprocess") >> Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests") >> Cc: [email protected] >> >> Signed-off-by: Chaitanya Babu Talluri <[email protected]>
<...> > > Any Review Please!! > cc'ed Bruce & Thomas. What do you think getting strlcat() patch first and updating this patch to use strlcat()? Are we OK to get strlcat as the default API? Thanks, ferruh

