On 1/21/2019 11:43 AM, Van Haaren, Harry wrote:
>> -----Original Message-----
>> From: Rao, Nikhil
>> Sent: Saturday, January 19, 2019 2:01 PM
>> To: Van Haaren, Harry <harry.van.haa...@intel.com>
>> Cc: dev@dpdk.org; Rao, Nikhil <nikhil....@intel.com>
>> Subject: [PATCH] service: fix parameter type
>>
>> The type of value parameter to rte_service_attr_get
>> should be uint64_t *, since the attributes
>> are of type uint64_t.
>>
>> Fixes: 4d55194d76a4 ("service: add attribute get function")
>>
>> Reviewed-by: Gage Eads <gage.e...@intel.com>
>> Signed-off-by: Nikhil Rao <nikhil....@intel.com>
>
> Acked-by: Harry van Haaren <harry.van.haa...@intel.com>
>
>> ---
>> lib/librte_eal/common/include/rte_service.h | 2 +-
>> lib/librte_eal/common/rte_service.c | 2 +-
>> test/test/test_service_cores.c | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> For 19.02, I assume this will require the ABI change announcement. I will
>> post it once this patch is acked.
>
> Correct - this breaks API and ABI, so certainly will need an announce.
Hi Nikhil P,
Can you please send a new version of this patch, that includes removing the
deprecation notice too? (Keeping the ack)
Thanks,
ferruh
>
> Thanks for the fixup, -Harry
>
