Hi Arek >-----Original Message----- >From: Kusztal, ArkadiuszX <[email protected]> >Sent: 12 February 2019 16:42 >To: Shally Verma <[email protected]>; Ayuj Verma <[email protected]>; >Trahe, Fiona <[email protected]> >Cc: [email protected]; Kanaka Durga Kotamarthy <[email protected]>; >Sunila Sahu <[email protected]>; >[email protected] >Subject: RE: [PATCH 0/3] adding op-type crt sign and decrypt > >Hi Shally, Ayuj > >Answers with [AK] > >> -----Original Message----- >> From: Shally Verma [mailto:[email protected]] >> Sent: Tuesday, February 12, 2019 6:27 AM >> To: Kusztal, ArkadiuszX <[email protected]>; Ayuj Verma >> <[email protected]>; Trahe, Fiona <[email protected]> >> Cc: [email protected]; Kanaka Durga Kotamarthy >> <[email protected]>; Sunila Sahu <[email protected]>; >> [email protected] >> Subject: RE: [PATCH 0/3] adding op-type crt sign and decrypt >> >> HI Arek, >> >> From: Kusztal, ArkadiuszX <[email protected]> >> Sent: 11 February 2019 17:11 >> To: Ayuj Verma <[email protected]>; Trahe, Fiona >> <[email protected]>; Shally Verma <[email protected]> >> Cc: [email protected] >> Subject: [EXT] RE: [PATCH 0/3] adding op-type crt sign and decrypt >> >> External Email >> ________________________________________ >> Hi Ayuj, >> >> Few comments from me. >> >> Some PMDs can only support RSA private key operations using CRT keys >> (quintuple) only. Thus it is required to add in PMD RSA xform capability >> which key type is supported to perform sign and decrypt ops. >> >> >> Thus add an another op_type RTE_CRYPTO_OP_TYPE_SIGN_CRT and >> RTE_CRYPTO_OP_TYPE_DECRYPT_CRT, which would mean perform an >> private key op using CRT keys (quintuple) only. >> [AK] - What would be the purpose of enum rte_crypto_rsa_priv_key_type >> key_type in RSA XFORM then? >> >> [Shally] PMDs, like openssl, can support private key ops with both key type >> i.e. one can invoke RSA_Sign() with quintuple keys or exponent keys. >> Openssl in its capability would reflect it support ops with both key types. >> that's why key_type is still required in xform. > >[AK] But still I wonder if we could not just use this enum to distinguish >between crt and mod exp rsa? >I am not very keen on adding SIGN_CRT op type as it is RSA only. Another >option would be to add flags to rsa op like uint64_t flags; [Shally] Ok .. you mean as feature flag? Example, RTE_CRYPTODEV_ASYM_FF_RSA_PRIV_KEY_OP_CRT?
Thanks Shally ... >> Regards, >> Arek
