Hi Yipeng, Thanks for your review and acknowledgement. I did think about braces on separate lines. One concern is, in this way, extra indent will be needed and make it hard to keep code lines within 80 characters. So I made the style compromise.
Regards, /Ruifeng > -----Original Message----- > From: Wang, Yipeng1 <[email protected]> > Sent: Thursday, February 14, 2019 4:32 > To: Ruifeng Wang (Arm Technology China) <[email protected]>; > [email protected] > Cc: [email protected]; Honnappa Nagarahalli > <[email protected]>; Gavin Hu (Arm Technology China) > <[email protected]>; nd <[email protected]> > Subject: RE: [PATCH v2] hash: optimize signature compare by using neon > intrinsic > > Hi, Ruifeng, > > I don't have an ARM Platform at hand to test but I gone through the code > against a NEON instruction manual, and the logic looks good to me. One small > comment is the coding style for switch case, I think it is more common to > leave the braces on their own lines. > > Otherwise: > Acked-by: Yipeng Wang<[email protected]> > > > >-----Original Message----- > >From: Ruifeng Wang [mailto:[email protected]] > >Sent: Monday, February 11, 2019 11:01 PM > >To: Wang, Yipeng1 <[email protected]>; [email protected] > >Cc: [email protected]; [email protected]; [email protected]; > >[email protected]; Ruifeng Wang <[email protected]> > >Subject: [PATCH v2] hash: optimize signature compare by using neon > >intrinsic > > > >Implemented signature compare function based on neon intrinsic. > >Hash bulk lookup had 3% - 6% performance gain after optimization. > > > >Signed-off-by: Ruifeng Wang <[email protected]> > >Reviewed-by: Gavin Hu <[email protected]>
