Re: [dpdk-dev] [PATCH v2 1/2] eal: fix potential incorrect pinning for ctrl threads

[Burakov, Anatoly]

On 14-Feb-19 1:30 PM, David Marchand wrote:

pthread_setaffinity_np returns a >0 value on error.
We could end up letting the ctrl threads on the current process cpu
affinity.

Fixes: d651ee4919cd ("eal: set affinity for control threads")
Signed-off-by: David Marchand <david.march...@redhat.com>
---
  lib/librte_eal/common/eal_common_thread.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/eal_common_thread.c 
b/lib/librte_eal/common/eal_common_thread.c
index 48ef4d6..a3985ce 100644
--- a/lib/librte_eal/common/eal_common_thread.c
+++ b/lib/librte_eal/common/eal_common_thread.c
@@ -209,7 +209,7 @@ static void *rte_thread_init(void *arg)
                CPU_SET(rte_get_master_lcore(), &cpuset);

ret = pthread_setaffinity_np(*thread, sizeof(cpuset), &cpuset);

-       if (ret < 0)
+       if (ret)
                goto fail;

ret = pthread_barrier_wait(&params->configured);

CC: stable?

--
Thanks,
Anatoly