On Tue, Feb 26, 2019 at 02:18:09PM +0000, Andrius Sirvys wrote: > When building with mason, checks if the compiler is icc. If they match, > the warning_flags are changed to ensure icc compilation is successful. > > Disabled error 3656: "variable may be used before its value is set" > in librte_telemetry, bnx2x, ixgbe and sfc as they were false positives. > > Signed-off-by: Andrius Sirvys <andrius.sir...@intel.com> > Tested-by: Ferruh Yigit <ferruh.yi...@intel.com> > ---
Looks ok to me. Acked-by: Bruce Richardson <bruce.richard...@intel.com> If you are up for it, could you also do an additional patch to add an icc build to "test-meson-builds.sh" if icc is found on the system?
