> -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, March 1, 2019 3:13 PM > To: Eads, Gage <gage.e...@intel.com> > Cc: Olivier Matz <olivier.m...@6wind.com>; dev@dpdk.org; > arybche...@solarflare.com; Richardson, Bruce <bruce.richard...@intel.com>; > Ananyev, Konstantin <konstantin.anan...@intel.com>; gavin...@arm.com; > honnappa.nagaraha...@arm.com; n...@arm.com > Subject: Re: FW: [PATCH 5/7] stack: add non-blocking stack implementation > > 01/03/2019 21:53, Eads, Gage: > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > > On Fri, Feb 22, 2019 at 10:06:53AM -0600, Gage Eads wrote: > > > > +#define STACK_F_NB 0x0001 > > > > > > What about adding the RTE_ prefix? > > > > I'm fine with either, but there's precedent for flag macros named > > <module_name>_*. E.g. RING_F_*, MEMPOOL_F_*, ETH_*, and > SERVICE_F_*. > > They should be fixed. > Every public symbols should be prefixed to avoid namespace conflict. > At first, we should rename them and keep the old name as an alias. > Later, non-prefixed names should be removed after a deprecation notice. > Ok, will fix. Thanks, Gage
- [dpdk-dev] [PATCH 0/7] Subject: [PATCH ...] Add stack libr... Gage Eads
- [dpdk-dev] [PATCH 1/7] stack: introduce rte stack lib... Gage Eads
- Re: [dpdk-dev] [PATCH 1/7] stack: introduce rte s... Olivier Matz
- [dpdk-dev] [PATCH 2/7] mempool/stack: convert mempool... Gage Eads
- Re: [dpdk-dev] [PATCH 2/7] mempool/stack: convert... Olivier Matz
- [dpdk-dev] [PATCH 5/7] stack: add non-blocking stack ... Gage Eads
- Re: [dpdk-dev] [PATCH 5/7] stack: add non-blockin... Olivier Matz
- [dpdk-dev] FW: [PATCH 5/7] stack: add non-blo... Eads, Gage
- Re: [dpdk-dev] FW: [PATCH 5/7] stack: add... Thomas Monjalon
- Re: [dpdk-dev] FW: [PATCH 5/7] stack... Eads, Gage
- [dpdk-dev] [PATCH 7/7] mempool/stack: add non-blockin... Gage Eads
- Re: [dpdk-dev] [PATCH 7/7] mempool/stack: add non... Olivier Matz
- [dpdk-dev] [PATCH 4/7] test/stack: add stack perf tes... Gage Eads
- Re: [dpdk-dev] [PATCH 4/7] test/stack: add stack ... Olivier Matz
- [dpdk-dev] [PATCH 3/7] test/stack: add stack test Gage Eads
- Re: [dpdk-dev] [PATCH 3/7] test/stack: add stack ... Olivier Matz
- [dpdk-dev] [PATCH 6/7] test/stack: add non-blocking s... Gage Eads
- Re: [dpdk-dev] [PATCH 6/7] test/stack: add non-bl... Olivier Matz
- [dpdk-dev] [PATCH v2 0/8] Add stack library and new m... Gage Eads