Hi Maryam, On 08/19/2015 02:53 PM, Tahhan, Maryam wrote: >> From: Olivier MATZ [mailto:olivier.matz at 6wind.com] >> Sent: Monday, August 17, 2015 3:54 PM >> To: Tahhan, Maryam; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v6 4/9] ethdev: remove HW specific stats in >> stats structs >> >> Hi Maryam, >> >> On 07/15/2015 03:11 PM, Maryam Tahhan wrote: >>> Remove non generic stats in rte_stats_strings and mark the relevant >>> fields in struct rte_eth_stats as deprecated. >>> >> >> Looking again at this patch, I'm wondering if "imissed" should be kept >> instead >> of beeing deprecated. I think it could be useful to differentiate ierrors >> from >> imissed, and it's not a hw-specific statistic. What do you think? >> >> One more comment: it seems these fields are marked as deprecated but they >> are still used on other drivers (e1000, i40e, ...). >> >> Regards, >> Olivier >> > > > Hi Olivier > I can remove the deprecated status for imissed to leave the differentiation > between errors and missed packets. > igb and i40e will be updated soon to reflect this. I marked them as > deprecated to deter their use in the future. Older instances/use will need to > be resolved.
From my point of view, yes, I think it's better to keep different stats for imissed and ierrors as it can be useful to determinine the cause of packet losses. If nobody disagrees, I think we could remove the deprecation notice for imissed. Regards, Olivier
