Hi,
While Coverity was down recently we looked at some other static code analysis
tools available to open source communities.
One of these is a new interesting tool called LGTM:
https://lgtm.com/projects/g/DPDK/dpdk/overview/
I ran a crosscheck git-blame and identified the probable* authors of the
defects. Can the people on the TO: list have a look at the defects that appear
to come from their code and submit fixes as necessary. See the full list below
for names, files and line numbers. Some of these are pretty minor but some are
definitely defects.
* git-blame may not be accurate in this case because the code may have changed
since the defect was introduced. The GUI has more information on the commits
that introduced some of the defects but that information wasn't available
outside the GUI.
You can drill down into the files using this link:
https://lgtm.com/projects/g/DPDK/dpdk/latest/files/
The defects are shown below.
John
Author File
Line
====== ====
====
ajit.khapa...@broadcom.com drivers/net/bnxt/bnxt_hwrm.c
256
ajit.khapa...@broadcom.com drivers/net/bnxt/bnxt_ethdev.c
3308
ajit.khapa...@broadcom.com drivers/net/bnxt/bnxt_ethdev.c
3316
alejandro.luc...@netronome.com drivers/net/nfp/nfpcore/nfp_target.h
547
allain.leg...@windriver.com drivers/net/avp/avp_ethdev.c
272
amore...@solarflare.com drivers/net/sfc/base/medford2_nic.c
21
anatoly.bura...@intel.com
lib/librte_eal/common/eal_common_fbarray.c 55
andriy.berestovs...@caviumnetworks.com usertools/cpu_layout.py
25
artem.andr...@oktetlabs.ru
drivers/mempool/bucket/rte_mempool_bucket.c 546
arybche...@solarflare.com drivers/net/sfc/base/ef10_ev.c
908
arybche...@solarflare.com drivers/net/sfc/base/ef10_filter.c
432
arybche...@solarflare.com drivers/net/sfc/base/ef10_filter.c
622
arybche...@solarflare.com drivers/net/sfc/base/ef10_filter.c
815
arybche...@solarflare.com drivers/net/sfc/base/ef10_filter.c
1329
arybche...@solarflare.com drivers/net/sfc/base/ef10_impl.h
69
arybche...@solarflare.com drivers/net/sfc/base/ef10_mac.c
289
arybche...@solarflare.com drivers/net/sfc/base/ef10_mcdi.c
221
arybche...@solarflare.com drivers/net/sfc/base/ef10_nic.c
1971
arybche...@solarflare.com drivers/net/sfc/base/ef10_nic.c
2454
arybche...@solarflare.com drivers/net/sfc/base/ef10_nic.c
2461
arybche...@solarflare.com drivers/net/sfc/base/ef10_nvram.c
2421
arybche...@solarflare.com drivers/net/sfc/base/ef10_nvram.c
2422
arybche...@solarflare.com drivers/net/sfc/base/ef10_rx.c
997
arybche...@solarflare.com drivers/net/sfc/base/ef10_rx.c
999
arybche...@solarflare.com drivers/net/sfc/base/ef10_tx.c
230
arybche...@solarflare.com drivers/net/sfc/base/ef10_tx.c
232
arybche...@solarflare.com drivers/net/sfc/base/ef10_tx.c
703
arybche...@solarflare.com drivers/net/sfc/base/ef10_tx.c
710
arybche...@solarflare.com drivers/net/sfc/base/ef10_tx.c
749
arybche...@solarflare.com drivers/net/sfc/base/ef10_tx.c
751
arybche...@solarflare.com drivers/net/sfc/base/efx.h
2906
arybche...@solarflare.com drivers/net/sfc/base/efx_impl.h
17
arybche...@solarflare.com drivers/net/sfc/base/efx_sram.c
30
arybche...@solarflare.com drivers/net/sfc/base/efx_sram.c
151
arybche...@solarflare.com drivers/net/sfc/base/hunt_nic.c
153
arybche...@solarflare.com drivers/net/sfc/sfc.c
188
arybche...@solarflare.com drivers/net/sfc/sfc_ef10_essb_rx.c
139
arybche...@solarflare.com drivers/net/sfc/sfc_ef10_essb_rx.c
525
bruce.richard...@intel.com drivers/event/sw/sw_evdev_xstats.c
253
bruce.richard...@intel.com
drivers/net/virtio/virtio_user/vhost_kernel_tap.h 1
bruce.richard...@intel.com lib/librte_acl/acl_run_sse.h
1
changchun.ouy...@intel.com drivers/net/ixgbe/base/ixgbe_phy.c
207
changchun.ouy...@intel.com drivers/net/ixgbe/base/ixgbe_phy.c
211
ciara.po...@intel.com usertools/dpdk-telemetry-client.py
75
ciara.po...@intel.com usertools/dpdk-telemetry-client.py
90
ciara.po...@intel.com usertools/dpdk-telemetry-client.py
29
ciara.po...@intel.com usertools/dpdk-telemetry-client.py
44
ciara.po...@intel.com usertools/dpdk-telemetry-client.py
102
ciara.po...@intel.com
lib/librte_telemetry/rte_telemetry_parser.c 453
ciara.po...@intel.com
lib/librte_telemetry/rte_telemetry_parser.c 518
david.march...@6wind.com drivers/bus/pci/linux/pci_uio.c
396
david.march...@6wind.com drivers/bus/pci/linux/pci_uio.c
557
fiona.tr...@intel.com drivers/common/qat/qat_device.c
195
g.si...@nxp.com drivers/crypto/caam_jr/caam_jr.c
2270
g.si...@nxp.com drivers/crypto/caam_jr/caam_jr.c
2283
gaetan.ri...@6wind.com drivers/net/failsafe/failsafe_private.h
124
gaetan.ri...@6wind.com drivers/net/failsafe/failsafe_private.h
179
gprathyu...@caviumnetworks.com usertools/dpdk-devbind.py
389
gprathyu...@caviumnetworks.com usertools/dpdk-devbind.py
396
gprathyu...@caviumnetworks.com usertools/dpdk-devbind.py
405
gprathyu...@caviumnetworks.com usertools/dpdk-devbind.py
414
gprathyu...@caviumnetworks.com usertools/dpdk-devbind.py
452
gprathyu...@caviumnetworks.com usertools/dpdk-devbind.py
459
gprathyu...@caviumnetworks.com usertools/dpdk-devbind.py
206
harry.van.haa...@intel.com drivers/event/sw/sw_evdev_selftest.c
388
harry.van.haa...@intel.com drivers/event/sw/sw_evdev_selftest.c
480
harry.van.haa...@intel.com drivers/event/sw/sw_evdev_selftest.c
549
harry.van.haa...@intel.com drivers/event/sw/sw_evdev_selftest.c
710
harry.van.haa...@intel.com drivers/event/sw/sw_evdev_selftest.c
798
harry.van.haa...@intel.com drivers/event/sw/sw_evdev_selftest.c
2029
harry.van.haa...@intel.com drivers/event/sw/sw_evdev_selftest.c
2128
harry.van.haa...@intel.com drivers/event/sw/sw_evdev_selftest.c
2178
harry.van.haa...@intel.com drivers/event/sw/sw_evdev_selftest.c
2288
harry.van.haa...@intel.com drivers/event/sw/sw_evdev_selftest.c
2375
harry.van.haa...@intel.com drivers/event/sw/sw_evdev_selftest.c
2419
harry.van.haa...@intel.com drivers/net/virtio/virtio_rxtx.c
1120
hemant.agra...@nxp.com drivers/bus/fslmc/qbman/qbman_portal.c
934
hemant.agra...@nxp.com drivers/bus/fslmc/qbman/qbman_portal.c
1000
hemant.agra...@nxp.com drivers/mempool/dpaa/dpaa_mempool.c
299
hemant.agra...@nxp.com drivers/bus/dpaa/base/qbman/qman.h
1
hemant.agra...@nxp.com
drivers/bus/fslmc/qbman/include/fsl_qbman_debug.h 1
huawei....@intel.com lib/librte_vhost/vhost_user.h
5
igor.russk...@aquantia.com
drivers/net/atlantic/hw_atl/hw_atl_utils.c 465
intel.com usertools/cpu_layout.py
61
intel.com usertools/cpu_layout.py
7
intel.com usertools/dpdk-devbind.py
10
intel.com usertools/dpdk-devbind.py
347
intel.com usertools/dpdk-devbind.py
423
intel.com usertools/dpdk-devbind.py
432
intel.com drivers/net/e1000/base/e1000_i210.c
93
intel.com drivers/net/e1000/igb_rxtx.c
2278
intel.com drivers/net/ixgbe/ixgbe_rxtx.c
4497
intel.com drivers/net/e1000/base/e1000_82575.c
3415
intel.com drivers/net/e1000/base/e1000_82575.c
3419
intel.com drivers/net/ixgbe/base/ixgbe_phy.c
2165
intel.com drivers/net/ixgbe/base/ixgbe_phy.c
2169
intel.com drivers/net/ixgbe/ixgbe_pf.c
227
intel.com drivers/net/ixgbe/ixgbe_pf.c
381
intel.com drivers/net/e1000/base/e1000_manage.c
160
intel.com lib/librte_sched/rte_sched.c
752
jblu...@infradead.org drivers/net/bonding/rte_eth_bond_pmd.c
3314
jerin.ja...@caviumnetworks.com drivers/net/thunderx/nicvf_rxtx.c
448
jerin.ja...@caviumnetworks.com drivers/net/thunderx/nicvf_rxtx.c
537
jfreim...@redhat.com drivers/net/virtio/virtio_ring.h
169
jianfeng....@intel.com drivers/net/virtio/virtio_user/vhost.h
5
jianjay.z...@huawei.com
drivers/crypto/virtio/virtio_cryptodev.c 1253
jianjay.z...@huawei.com
drivers/crypto/virtio/virtio_cryptodev.c 1337
jianjay.z...@huawei.com
drivers/crypto/virtio/virtio_cryptodev.c 778
jingjing...@intel.com drivers/net/i40e/i40e_rxtx.c
1806
jingjing...@intel.com drivers/net/i40e/i40e_rxtx.c
2144
johnd...@cisco.com drivers/net/enic/enic_flow.c
1389
johnd...@cisco.com drivers/net/enic/enic_flow.c
1516
johnd...@cisco.com drivers/net/enic/enic_flow.c
1517
kamil.rytarow...@caviumnetworks.com usertools/dpdk-devbind.py
157
kirill.rybalche...@intel.com drivers/net/i40e/i40e_ethdev.c
8817
kirill.rybalche...@intel.com drivers/net/i40e/i40e_fdir.c
2035
kirill.rybalche...@intel.com drivers/net/ixgbe/ixgbe_fdir.c
1459
konstantin.anan...@intel.com lib/librte_acl/acl_gen.c
373
konstantin.anan...@intel.com lib/librte_acl/acl_run_avx2.h
79
konstantin.anan...@intel.com lib/librte_acl/acl_bld.c
1384
konstantin.anan...@intel.com lib/librte_acl/acl_bld.c
1394
konstantin.anan...@intel.com lib/librte_acl/rte_acl.c
215
konstantin.anan...@intel.com lib/librte_acl/rte_acl.c
274
konstantin.anan...@intel.com lib/librte_acl/rte_acl.c
304
konstantin.anan...@intel.com lib/librte_bpf/bpf_exec.c
145
konstantin.anan...@intel.com lib/librte_bpf/bpf_exec.c
179
kuma...@chelsio.com drivers/net/cxgbe/sge.c
1193
kuma...@chelsio.com drivers/net/cxgbe/sge.c
1204
kuma...@chelsio.com drivers/net/cxgbe/sge.c
1217
kuma...@chelsio.com drivers/net/cxgbe/sge.c
1219
kuma...@chelsio.com drivers/net/cxgbe/sge.c
1227
kuma...@chelsio.com drivers/net/cxgbe/sge.c
1229
liang.j...@intel.com drivers/event/opdl/opdl_ring.c
256
liang.j...@intel.com drivers/event/opdl/opdl_ring.c
260
liang.j...@intel.com drivers/event/opdl/opdl_ring.c
263
liang.j...@intel.com drivers/event/opdl/opdl_ring.c
277
liang.j...@intel.com drivers/event/opdl/opdl_ring.c
281
liang.j...@intel.com drivers/event/opdl/opdl_ring.c
284
liang-min.w...@intel.com drivers/net/e1000/igb_regs.h
148
linvi...@tuxdriver.com
drivers/net/af_packet/rte_eth_af_packet.c 700
linvi...@tuxdriver.com
drivers/net/af_packet/rte_eth_af_packet.c 790
maciejx.t.gajdz...@intel.com drivers/net/bonding/rte_eth_bond_pmd.c
48
mo...@mellanox.com drivers/net/failsafe/failsafe_ops.c
479
mspen...@solarflare.com drivers/net/sfc/base/ef10_ev.c
956
nhor...@tuxdriver.com usertools/dpdk-pmdinfo.py
225
nhor...@tuxdriver.com usertools/dpdk-pmdinfo.py
70
nhor...@tuxdriver.com usertools/dpdk-pmdinfo.py
112
nhor...@tuxdriver.com usertools/dpdk-pmdinfo.py
181
nipun.gu...@nxp.com drivers/bus/fslmc/qbman/qbman_portal.c
803
nipun.gu...@nxp.com drivers/bus/fslmc/qbman/qbman_portal.c
860
pablo.de.lara.gua...@intel.com drivers/net/bonding/rte_eth_bond_args.c
228
pablo.de.lara.gua...@intel.com lib/librte_efd/rte_efd.c
584
pablo.de.lara.gua...@intel.com lib/librte_hash/rte_cuckoo_hash.c
570
paul.m.stillwell...@intel.com drivers/net/ice/base/ice_controlq.c
818
paul.m.stillwell...@intel.com drivers/net/ice/base/ice_controlq.c
896
paul.m.stillwell...@intel.com drivers/net/ice/base/ice_controlq.c
906
pavel.bel...@aquantia.com drivers/net/atlantic/atl_ethdev.c
593
pbhagavat...@caviumnetworks.com drivers/event/octeontx/timvf_evdev.c
98
pbhagavat...@caviumnetworks.com drivers/event/octeontx/timvf_evdev.c
176
qiming.y...@intel.com drivers/net/ixgbe/base/ixgbe_common.c
5043
radu.nico...@intel.com drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c
101
radu.nico...@intel.com drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c
102
radu.nico...@intel.com drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c
103
radu.nico...@intel.com drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c
104
rahul.lakkire...@chelsio.com drivers/net/cxgbe/base/t4_hw.c
3797
rahul.lakkire...@chelsio.com drivers/net/cxgbe/cxgbe_ethdev.c
624
rahul.lakkire...@chelsio.com drivers/net/cxgbe/sge.c
1252
rahul.lakkire...@chelsio.com drivers/net/cxgbe/sge.c
1299
rahul.lakkire...@chelsio.com drivers/net/cxgbe/sge.c
1302
rasesh.m...@cavium.com drivers/net/qede/base/ecore_dev.c
2843
rasesh.m...@cavium.com
drivers/net/qede/base/ecore_init_fw_funcs.c 211
rasesh.m...@cavium.com
drivers/net/qede/base/ecore_init_fw_funcs.c 493
rasesh.m...@qlogic.com drivers/net/qede/base/ecore_chain.h
190
rasesh.m...@qlogic.com drivers/net/qede/base/ecore_dev.c
3070
rasesh.m...@qlogic.com drivers/net/qede/base/ecore_dev.c
3089
rasesh.m...@qlogic.com drivers/net/qede/base/ecore_int.c
893
rasesh.m...@qlogic.com drivers/net/qede/base/ecore_int.c
1154
rasesh.m...@qlogic.com drivers/net/qede/base/ecore_int.c
1994
rasesh.m...@qlogic.com drivers/net/qede/base/ecore_int_api.h
66
rasesh.m...@qlogic.com
drivers/net/qede/base/ecore_init_fw_funcs.c 972
rasesh.m...@qlogic.com drivers/net/qede/base/ecore_sriov.c
125
rasesh.m...@qlogic.com drivers/net/qede/base/ecore_hw.c
588
r...@semihalf.com drivers/net/ena/base/ena_com.c
377
sas...@lightbitslabs.com drivers/net/ena/ena_ethdev.c
2572
sas...@lightbitslabs.com drivers/net/ena/ena_ethdev.c
2584
sas...@lightbitslabs.com drivers/net/ena/ena_ethdev.c
2595
sergio.gonzalez.mon...@intel.com
lib/librte_eal/common/arch/x86/rte_cycles.c 105
shag...@chelsio.com drivers/net/cxgbe/cxgbe_filter.c
196
shag...@chelsio.com drivers/net/cxgbe/cxgbe_filter.c
292
shag...@chelsio.com drivers/net/cxgbe/cxgbe_filter.c
316
shag...@chelsio.com drivers/net/cxgbe/cxgbe_main.c
387
shreyansh.j...@nxp.com drivers/net/dpaa/dpaa_rxtx.c
307
shreyansh.j...@nxp.com drivers/net/dpaa/dpaa_rxtx.c
323
shreyansh.j...@nxp.com drivers/net/dpaa/dpaa_rxtx.c
339
slawomirx.mrozow...@intel.com
drivers/crypto/scheduler/scheduler_pmd_ops.c 474
somnath.ko...@broadcom.com drivers/net/bnxt/bnxt_hwrm.c
3359
ssuj...@cisco.com drivers/net/enic/base/vnic_dev.c
224
step...@networkplumber.org drivers/net/tap/tap_log.h
1
step...@networkplumber.org
lib/librte_eal/common/eal_common_hexdump.c 39
step...@networkplumber.org
lib/librte_eal/common/eal_common_hexdump.c 41
step...@networkplumber.org
lib/librte_eal/common/eal_common_hexdump.c 46
sthem...@microsoft.com drivers/net/netvsc/hn_rxtx.c
126
sthem...@microsoft.com drivers/net/netvsc/hn_nvs.h
1
sthem...@microsoft.com drivers/net/netvsc/hn_rndis.h
1
sthem...@microsoft.com drivers/net/netvsc/hn_var.h
1
sunil.k...@nxp.com drivers/net/dpaa2/dpaa2_flow.c
1726
tianfei.zh...@intel.com
drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c 267
tianfei.zh...@intel.com
drivers/raw/ifpga_rawdev/base/opae_hw_api.h 41
tianfei.zh...@intel.com
drivers/raw/ifpga_rawdev/base/opae_hw_api.h 201
yipeng1.w...@intel.com lib/librte_member/rte_member_vbf.c
121
zhiyong.y...@intel.com drivers/net/vhost/rte_eth_vhost.c
363
