02/04/2019 21:56, Thomas Monjalon:
> 02/04/2019 05:54, Anand Rawat:
> > Added rte_os.h files to support OS specific functionality.
> > Updated build system to contain OS headers in the include
> > path.
> >
> > Signed-off-by: Anand Rawat <anand.ra...@intel.com>
> > Reviewed-by: Pallavi Kadam <pallavi.ka...@intel.com>
> > ---
> > --- a/meson.build
> > +++ b/meson.build
> > -global_inc = include_directories('.', 'config',
> > 'lib/librte_eal/common/include')
> > +global_inc = include_directories('.', 'config',
> > + 'lib/librte_eal/common/include',
> > +
> > 'lib/librte_eal/@0@/eal/include'.format(host_machine.system()))
>
> After having worked on rte_kni_common.h which is only in Linux,
> I think we should add rte_os.h in meson file of each OS:
> - lib/librte_eal/linux/eal/meson.build
> - lib/librte_eal/freebsd/eal/meson.build
> - lib/librte_eal/windows/eal/meson.build
I confirm:
"global_inc" is used in "includes" variable but not in "headers" variable,
so rte_os.h is not installed as other files in "headers".
We must fill "env_headers" which is pulled by:
headers = common_headers + env_headers
I will fix it before merging in master if you agree.
