Hi Akhil, Thanks a lot for that, let me know if anything else is needed.
> -----Original Message----- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, April 3, 2019 10:42 AM > To: Kusztal, ArkadiuszX <arkadiuszx.kusz...@intel.com>; dev@dpdk.org > Cc: Trahe, Fiona <fiona.tr...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v5 2/4] crypto/qat: add asymmetric > cryptography PMD > > Hi Arek, > > On 3/28/2019 7:07 PM, Arek Kusztal wrote: > > This patch adds Poll Mode Driver for asymmetric crypto functions of > > Intel QuickAssist Technology hardware. > > > > It contains plain driver with no functions implmented, specific > > algorithms will be introduced in separate patches. > > > > This patch depends on a QAT PF driver for device initialization. See > > the file docs/guides/cryptodevs/qat.rst for configuration details. > > > > Signed-off-by: Arek Kusztal <arkadiuszx.kusz...@intel.com> > > --- > > config/common_base | 1 + > > doc/guides/cryptodevs/qat.rst | 7 + > > drivers/common/qat/Makefile | 8 + > > drivers/common/qat/qat_device.h | 12 +- > > drivers/common/qat/qat_qp.c | 8 + > > drivers/crypto/qat/meson.build | 5 +- > > drivers/crypto/qat/qat_asym.c | 236 ++++++++++++++++++++++ > > drivers/crypto/qat/qat_asym.h | 97 +++++++++ > > drivers/crypto/qat/qat_asym_capabilities.h | 10 + > > drivers/crypto/qat/qat_asym_pmd.c | 308 > +++++++++++++++++++++++++++++ > > drivers/crypto/qat/qat_asym_pmd.h | 50 +++++ > > drivers/crypto/qat/qat_sym_pmd.c | 1 - > > drivers/crypto/qat/qat_sym_pmd.h | 3 +- > > mk/rte.app.mk | 1 + > > 14 files changed, 742 insertions(+), 5 deletions(-) > > create mode 100644 drivers/crypto/qat/qat_asym.c > > create mode 100644 drivers/crypto/qat/qat_asym.h > > create mode 100644 drivers/crypto/qat/qat_asym_capabilities.h > > create mode 100644 drivers/crypto/qat/qat_asym_pmd.c > > create mode 100644 drivers/crypto/qat/qat_asym_pmd.h > > > > diff --git a/config/common_base b/config/common_base index > > 0b09a93..d1dd66a 100644 > > --- a/config/common_base > > +++ b/config/common_base > > @@ -545,6 +545,7 @@ CONFIG_RTE_LIBRTE_PMD_OCTEONTX_CRYPTO=y > > # > > CONFIG_RTE_LIBRTE_PMD_QAT=y > > CONFIG_RTE_LIBRTE_PMD_QAT_SYM=n > > +CONFIG_RTE_LIBRTE_PMD_QAT_ASYM=n > > # > > # Max. number of QuickAssist devices, which can be detected and > attached > > # > > diff --git a/doc/guides/cryptodevs/qat.rst > > b/doc/guides/cryptodevs/qat.rst index da9655c..53a8d61 100644 > > --- a/doc/guides/cryptodevs/qat.rst > > +++ b/doc/guides/cryptodevs/qat.rst > > @@ -101,7 +101,13 @@ of all the items described above, including the > padding at the end. > > Also, offset of data to authenticate "op.sym.auth.data.offset" > > must be such that points at the start of the COUNT bytes. > > > > +Asymmetric Crypto Service on QAT > > +------------------------------- > > doc/guides/cryptodevs/qat.rst:105: WARNING: Title underline too short. > > > here one '-' is less. I corrected this while applying the patch. > > > + > > +The QAT Asym PMD has support for: > > > > +Limitations > > +~~~~~~~~~~~ > >
