Re: [dpdk-dev] [PATCH v7 0/8] Add stack library and new mempool handler

[Eads, Gage]

> -----Original Message-----
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Wednesday, April 3, 2019 3:40 PM
> To: Eads, Gage <gage.e...@intel.com>
> Cc: dev@dpdk.org; olivier.m...@6wind.com; arybche...@solarflare.com;
> Richardson, Bruce <bruce.richard...@intel.com>; Ananyev, Konstantin
> <konstantin.anan...@intel.com>; gavin...@arm.com;
> honnappa.nagaraha...@arm.com; n...@arm.com
> Subject: Re: [dpdk-dev] [PATCH v7 0/8] Add stack library and new mempool
> handler
> 
> 03/04/2019 22:09, Gage Eads:
> > v7:
> > - Add rte_branch_prediction.h include to rte_stack_std.h for unlikely()
> > - Add rte_compat.h include to rte_stack.h for __rte_experimental
> 
> There is another error when compiling for Arm:
> 
> lib/librte_stack/rte_stack.h:76:2: error:
>       implicit declaration of function 'RTE_ASSERT'

Fix incoming. Looking through the rest of that header, I don't see any other 
externally defined macros/data structures/functions/etc. that would need 
another include.

Also note that v7's ci/Performance-Testing build fail 
(http://mails.dpdk.org/archives/test-report/2019-April/079261.html) is because 
dpdklab applied the patch on commit 3c45889189924067, which is older than the 
128-bit CAS patch.