03/04/2019 16:45, Bruce Richardson: > There are quite a few instances remaining in DPDK where snprintf is being > used for string copying. These were not being picked up by our existing > coccinelle script, but that can be fixed by editing the script and running > it against our code. In the process a bug was found and fixed in the > bonding pmd, where we were incorrectly specifiying the buffer length > parameter to snprintf. > > The actual replacement was done in two phases - first replacing all > instances where only the snprintf line in question needed changing, then > fixing the other instances where we also needed to add in the header > include. [Using two stages allowed the header addition to be automated too, > since we had a list of files where every one needed the header inclusion] > > > Bruce Richardson (5): > net/bonding: fix buffer length when printing strings > devtools/cocci: make strlcpy replacement smarter > devtools/cocci: create safer version of strlcpy script > replace snprintf with strlcpy without adding extra include > replace snprintf with strlcpy
Applied (with 2 rebase changes), thanks