Re: [dpdk-dev] [PATCH v6 2/2] app/pdump: enhance to support multi-core capture

[Pattan, Reshma]

> -----Original Message-----
> From: Varghese, Vipin
> 


Nit picks:

> 
> +The ``--multi`` command line option is optional argument. If passed,
> +capture will be running on unique cores for all ``--pdump`` options. If
> +ignored, capture will be running on single core for all ``--pdump`` options.
> +

Instead of just saying on single cores or on unique cores, worth mentioning  
uses the 1st core of eal coremask/corelist for single case.
For multi case uses the cores except the 1st in one in coremask? 

>  The ``--pdump`` command line option is mandatory and it takes various sub
> arguments which are described in  below section.


> +   $ sudo ./build/app/dpdk-pdump -l 3,4,5 -- --multi --pdump
> 'port=0,queue=*,rx-dev=/tmp/rx-1.pcap' --pdump 'port=1,queue=*,rx-
> dev=/tmp/rx-2.pcap'
> --
> 2.17.1

In the command if you pass anything --m/--mul/--mult/multi the command still 
succeeds..  Did you check the reason for that?

Thanks,
Reshma