> -----Original Message----- > From: Thomas Monjalon <[email protected]> > Sent: Friday, April 5, 2019 7:25 AM > To: Phil Yang (Arm Technology China) <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; Gavin > Hu (Arm Technology China) <[email protected]>; Honnappa Nagarahalli > <[email protected]>; nd <[email protected]> > Subject: Re: [dpdk-dev] [PATCH v3 1/3] packet_ordering: add statistics for > each worker thread > > Hi, > > 03/04/2019 08:59, Phil Yang: > > The current implementation using the '__sync' built-ins to synchronize > > statistics within worker threads. The '__sync' built-ins functions are > > full barriers which will affect the performance, so add a per worker > > packets statistics to remove the synchronisation between worker threads. > > > > Since the maximum core number can get to 256, so disable the per core > > stats print in default and add the --insight-worker option to enable it. > [...] > > Suggested-by: Honnappa Nagarahalli <[email protected]> > > Signed-off-by: Phil Yang <[email protected]> > > Reviewed-by: Gavin Hu <[email protected]> > > There is an error with clang: > > examples/packet_ordering/main.c:82:57: error: > suggest braces around initialization of subobject static struct > wkr_stats_per wkr_stats[RTE_MAX_LCORE] = {0};
Thanks, Thomas. It is my bad. I should test with the devtools/test-meson-builds.sh script instead of build with default meson compiler before sending it out. I have addressed this defect in the new version. Please review it. Thanks, Phil > >
