On Mon, 8 Apr 2019 13:07:33 +0000 "Iremonger, Bernard" <bernard.iremon...@intel.com> wrote:
> Hi Stephen, > > > -----Original Message----- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Tuesday, April 2, 2019 9:39 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger <step...@networkplumber.org> > > Subject: [dpdk-dev] [PATCH v4 2/3] examples/l3fwd: use reserved IPv4/IPv6 > > addresses > > > > The l3fwd example should use the IPv4 addresses defined in RFC5735 and the > > IPv6 addresses defined in RFC5180 for the L3 forwarding example Longest > > Prefix > > Match table. > > There should probably be a fixes line. > Also the commit line should have the "fix" keyword. The original behavior was not a bug. It was just a poor design choice. Therefore the lack of fixes tag is intentional. Also didn't want this patch to make it into stable release and risk breaking some existing test bed.