> -----Original Message-----
> From: Li Qiang [mailto:liq...@163.com]
> Sent: Wednesday, April 10, 2019 21:43
> To: Xu, Rosen <rosen...@intel.com>; Zhang, Tianfei
> <tianfei.zh...@intel.com>
> Cc: dev@dpdk.org; liq...@gmail.com; Li Qiang <liq...@163.com>
> Subject: [PATCH v2] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr
>
> In rte_fpga_do_pr() function, if 'stat' return error the 'file_fd' is never
> closed
> thus leading a fd leak. This patch avoids this.
It's a bug fix, so pls add 'Fix XXX'.
> Spotted by Coverity: CID 27441
It should be Coverity issue: 279441
> Signed-off-by: Li Qiang <liq...@163.com>
pls add:
Cc: sta...@dpdk.org
> ---
> Changes since v1: fill ret before goto close_fd per Rosen's review
>
> drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> index da772d026..eff001b59 100644
> --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> @@ -244,7 +244,8 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int
> port_id,
> if (ret) {
> IFPGA_RAWDEV_PMD_ERR("stat on bitstream file
> failed: %s\n",
> file_name);
> - return -EINVAL;
> + ret = -EINVAL;
> + goto close_fd;
> }
> buffer_size = file_stat.st_size;
> IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size);
> --
> 2.17.1
>
