> On May 2, 2019, at 8:01 AM, Dekel Peled <dek...@mellanox.com> wrote:
>
> Function mlx5_rxq_ibv_release() is called in several places.
> Before each call except one, the input parameter is validated to make
> sure it is not null.
>
> This patch adds the missing validation where it is missing.
>
> Fixes: af4f09f28294 ("net/mlx5: prefix all functions with mlx5")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Dekel Peled <dek...@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_rxq.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> index db8c340..c9c2a14 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -617,7 +617,8 @@
> */
> rxq_data = (*priv->rxqs)[i];
> rxq_ctrl = container_of(rxq_data, struct mlx5_rxq_ctrl, rxq);
> - mlx5_rxq_ibv_release(rxq_ctrl->ibv);
> + if (rxq_ctrl->ibv)
> + mlx5_rxq_ibv_release(rxq_ctrl->ibv);
Please take care of two more things.
1) In mlx5_rx_intr_disable(),
mlx5_rxq_ibv_get() isn't paired with mlx5_rxq_ibv_release()
This would need a separate patch.
2) In mlx5_rx_intr_vec_disable()
Please fix the comment having the old name - priv_rx_intr_vec_enable().
This should be mlx5_rx_intr_vec_enable()
No need to have a separate patch. You can fix it in this patch.
With the change,
Acked-by: Yongseok Koh <ys...@mellanox.com>
> }
> free:
> rte_intr_free_epoll_fd(intr_handle);
> --
> 1.8.3.1
>
