+1 Regards, Liron
-----Original Message----- From: Trahe, Fiona <[email protected]> Sent: Friday, May 3, 2019 9:10 PM To: Doherty, Declan <[email protected]>; [email protected]; [email protected]; Liron Himi <[email protected]>; Alan Winkowski <[email protected]> Cc: De Lara Guarch, Pablo <[email protected]>; [email protected]; Kusztal, ArkadiuszX <[email protected]>; Anoob Joseph <[email protected]>; Shally Verma <[email protected]>; [email protected]; Trahe, Fiona <[email protected]> Subject: [EXT] RE: [PATCH] doc: add cryptodev gcm iv deprecation notice External Email ---------------------------------------------------------------------- Forwarding to maintainers of the following crypto PMDs which may be affected by this: mvsam ccp openssl Can you review the 19.05 deprecation notice below and if in agreement, ack please - 3 acks are needed This is the related API change targeted at 19.08: https://patches.dpdk.org/patch/52886/ > -----Original Message----- > From: Akhil Goyal [mailto:[email protected]] > Sent: Tuesday, April 30, 2019 7:59 AM > To: Anoob Joseph <[email protected]>; [email protected] > Cc: Trahe, Fiona <[email protected]>; De Lara Guarch, Pablo > <[email protected]>; [email protected]; Kusztal, ArkadiuszX > <[email protected]> > Subject: RE: [PATCH] doc: add cryptodev gcm iv deprecation notice > > Hi Anoob/Shally, > > Could you please review this patch and provide Ack. > > Thanks, > Akhil > > > > > > > > This patch adds deprecation notice of changing iv behaviour when > > using Galois Counter Mode of operation. Right now IV of all > > supported sizes can be used. > > > > Signed-off-by: Arek Kusztal <[email protected]> > > --- > > doc/guides/rel_notes/deprecation.rst | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > b/doc/guides/rel_notes/deprecation.rst > > index ba39c2d..76eb166 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -87,3 +87,9 @@ Deprecation Notices > > * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the > > xforms > > structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and > > ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``. > > + > > +* cryptodev: support for using IV with all sizes is added, J0 still > > +can > > + be used but only when IV length in following structs > > +``rte_crypto_auth_xform``, > > + ``rte_crypto_aead_xform`` is set to zero. When IV length is > > +greater or equal > > + to one it means it represents IV, when is set to zero it means J0 > > +is used > > + directly, in this case 16 bytes of J0 need to be passed. > > -- > > 2.1.0
