On Wed, May 22, 2019 at 01:26:28AM +0530, [email protected] wrote: > From: Jerin Jacob <[email protected]> > > Drivers do not have ABI. > Skip the symbol check if map file under drivers directory. > > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") > > Cc: [email protected] > Cc: Neil Horman <[email protected]> > Sorry, but I'm not ok with this, because many of our DPDK PMDs have functions that get exported which are meant to be called by applications directly. The dpaa2 driver is a good example, the cryptodev scheduler is another. Take a look at their version.map files to see what I mean.
Unless we are willing to make drivers opaque objects that are only accessible from the [eth|crypto|etc]dev apis in the DPDK core, we have the potential for exported symbols, which means we have an ABI that has to be maintained, or at least recognized and reviewed for consistency Nacked-by: Neil Horman <[email protected]> > Signed-off-by: Jerin Jacob <[email protected]> > --- > devtools/check-symbol-change.sh | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh > index c5434f3bb..444beddad 100755 > --- a/devtools/check-symbol-change.sh > +++ b/devtools/check-symbol-change.sh > @@ -93,6 +93,14 @@ check_for_rule_violations() > if [ "$ar" = "add" ] > then > > + directory=`echo $mname | cut -d / -f 2` > + if [ "$directory" = "drivers" ] > + then > + # Drivers do not have ABI. Skip further > + # processing if the map file is under > + # drivers directory > + continue > + fi > if [ "$secname" = "unknown" ] > then > # Just inform the user of this occurrence, but > -- > 2.21.0 > >
