> -----Original Message----- > From: Bruce Richardson <[email protected]> > Sent: Wednesday, May 22, 2019 4:21 PM > To: Jerin Jacob Kollanukkaran <[email protected]> > Cc: Neil Horman <[email protected]>; [email protected]; > [email protected]; [email protected] > Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] devtools: skip the symbol check > when map file under drivers > > > > Sorry, but I'm not ok with this, because many of our DPDK PMDs have > > > functions that get exported which are meant to be called by > > > applications directly. The > > > > OK. Just to update my knowledge, Should those API needs to go through > > ABI/API depreciation process? > > > > Actually, I am concerned about the APIs, which is called between > > drviers not the application. For example, > > drivers/common/dpaax/rte_common_dpaax_version.map > > > > it is not interface to application rather it is for intra driver case. > > I think, I can change my logic to Skip the symbols which NOT starting with > rte_. > > Agree? > > > > Context: > > I am adding a new driver/common/octeontx2 directory and it has some > > API which Needs to shared between drivers not to the application. For > > me, it does not make sense to go through any ABI process in such case. > > > > > Maybe not, but other drivers will have APIs designed for apps to call > directly - > some NIC drivers have them, and I suspect that rawdev drivers will need > them a lot. Therefore, it's best to have the drivers directory scanned by our > tooling.
Agreed. But all of those API which called directly called from application is starts with rte_ symbol. How about skipping the symbols which is NOT start with rte_* example: drivers/common/octeontx/rte_common_octeontx_version.map drivers/common/dpaax/rte_common_dpaax_version.map
