Hello, On Wed, May 22, 2019 at 2:16 AM Wang, Yipeng1 <[email protected]> wrote:
> >-----Original Message----- > >From: David Marchand [mailto:[email protected]] > >Sent: Wednesday, May 15, 2019 12:57 AM > >To: [email protected] > >Cc: [email protected]; [email protected]; [email protected]; > Wang, Yipeng1 <[email protected]>; Gobriel, > >Sameh <[email protected]>; Richardson, Bruce < > [email protected]>; De Lara Guarch, Pablo > ><[email protected]> > >Subject: [PATCH 1/2] test/hash: use existing lcore API > > > >Prefer the existing apis rather than direct access the configuration > >structure. > > > >Fixes: c7eb0972e74b ("test/hash: add lock-free r/w concurrency") > >Fixes: 3f9aab961ed3 ("test/hash: check lock-free extendable bucket") > >Cc: [email protected] > > > >Signed-off-by: David Marchand <[email protected]> > >--- > > app/test/test_hash_readwrite_lf.c | 29 ++++++++++++++--------------- > > 1 file changed, 14 insertions(+), 15 deletions(-) > > > > [Wang, Yipeng] > > Hi, David, I tested the patch and the test case seems now frozen after > running in the middle. Have you seen same thing? > > I include the original author Dharmik for the file for more reviews. > > > Output: > > " > .... > > Test: Hash add - key shift, Hash lookup - miss > > Number of readers: 1 > Cycles per lookup: 112 > > Number of readers: 2 > Cycles per lookup: 113 > > Number of readers: 4 > Cycles per lookup: 116 > > ** With bulk-lookup ** > > Number of readers: 1 > Cycles per lookup: 41 > > Number of readers: 2 > Cycles per lookup: 40 > > Number of readers: 4 > Cycles per lookup: 40 > > Test: Multi-add-lookup > > Number of writers: 2 > Number of readers: 1 > Cycles per lookup: 166 > > Number of writers: 2 > Number of readers: 2 > " > <Freezing here> > Thanks for reporting. I reproduced the issue. I did not catch it as I was starting the test with 4 cores on my laptop. I will post a fix and/or an updated patch. -- David Marchand
