Hi, Ferruh Thanks a lot. Your tips is really helpful, and I will follow this in the future.
-----Original Message----- From: Yigit, Ferruh Sent: Friday, May 24, 2019 9:12 PM To: Xu, Rosen <[email protected]>; Pei, Andy <[email protected]>; [email protected] Cc: Zhang, Roy Fan <[email protected]>; Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]> Subject: Re: [PATCH] net/i40e: i40e rework for ipn3ke On 5/24/2019 2:05 AM, Xu, Rosen wrote: > Hi, > >> -----Original Message----- >> From: Pei, Andy >> Sent: Thursday, May 23, 2019 17:15 >> To: [email protected] >> Cc: Pei, Andy <[email protected]>; Zhang, Roy Fan >> <[email protected]>; Zhang, Qi Z <[email protected]>; Wu, >> Jingjing <[email protected]>; Xing, Beilei >> <[email protected]>; Yigit, Ferruh <[email protected]>; Xu, >> Rosen <[email protected]> >> Subject: [PATCH] net/i40e: i40e rework for ipn3ke > >> Add switch_mode argument for i40e PF to specify the specific FPGA >> that i40e PF is connected to. >> i40e PF get link status update via the connected FPGA. >> >> Fixes: c60869e2b742 ("net/i40e: fix link status update") >> Cc: [email protected] >> Cc: [email protected] >> Cc: [email protected] >> Cc: [email protected] >> Cc: [email protected] >> Cc: [email protected] > > My understanding cc people should add in git send-email not in patch. "git send-email" is picking the names from commit log, so putting the names in the commit log is another way, but as you said at the end of the day we don't want names be in the git history. But what can be done is, putting the names after "---" works for both, those names still will be picked by "git send-email" and cc'ed automatically, and this information is part of the patch meanwhile they will be stripped automatically when merged, so they won't be in the git history without causing manual cleanup task to maintainers. > >> Signed-off-by: Andy Pei <[email protected]> >> --- <----- HERE >> drivers/net/i40e/i40e_ethdev.c | 128 >> +++++++++++++++++++++++++++++++++++++++-- >> 1 file changed, 122 insertions(+), 6 deletions(-) >> <...>
