> -----Original Message----- > From: Richardson, Bruce > Sent: Friday, May 17, 2019 3:21 AM > To: David Harton <dhar...@cisco.com> > Cc: dev@dpdk.org; Xing, Beilei <beilei.x...@intel.com>; Zhang, Qi Z > <qi.z.zh...@intel.com> > Subject: Re: [PATCH v3] net/i40e: Eliminate weak symbols in i40e_rxtx.c > > On Thu, May 16, 2019 at 02:28:03PM -0400, David Harton wrote: > > Use of weak symbols can hide makefile errors especially when custom > > makefiles are used. Removing the use of weak symbols to avoid a stub > > function being linked in production code. > > > > Signed-off-by: David Harton <dhar...@cisco.com> > > --- > > > > v3 - added CONFIG_RTE_LIBRTE_I40E_INC_VECTOR to makefile > > v2 - added CC_AVX2_SUPPORT check to code enabling avx2 vectors > > > Acked-by: Bruce Richardson <bruce.richard...@intel.com> Applied to dpdk-next-net-intel. Thanks Qi