[dpdk-dev] [PATCH 3/3] net/virtio: remove useless pointers checks

[Maxime Coquelin]

This patch removes uses checks on 'prev' pointer, as it
is always set before with a valid value.

Signed-off-by: Maxime Coquelin <maxime.coque...@redhat.com>
---
 drivers/net/virtio/virtio_rxtx.c | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
index 901490217c..7a6985e4e3 100644
--- a/drivers/net/virtio/virtio_rxtx.c
+++ b/drivers/net/virtio/virtio_rxtx.c
@@ -1518,9 +1518,7 @@ virtio_recv_pkts_inorder(void *rx_queue,
                        rx_pkts[nb_rx]->pkt_len += (uint32_t)(len[i]);
                        rx_pkts[nb_rx]->data_len += (uint16_t)(len[i]);
 
-                       if (prev)
-                               prev->next = rxm;
-
+                       prev->next = rxm;
                        prev = rxm;
                        seg_res -= 1;
                }
@@ -1704,9 +1702,7 @@ virtio_recv_mergeable_pkts(void *rx_queue,
                        rx_pkts[nb_rx]->pkt_len += (uint32_t)(len[i]);
                        rx_pkts[nb_rx]->data_len += (uint16_t)(len[i]);
 
-                       if (prev)
-                               prev->next = rxm;
-
+                       prev->next = rxm;
                        prev = rxm;
                        seg_res -= 1;
                }
@@ -1881,9 +1877,7 @@ virtio_recv_mergeable_pkts_packed(void *rx_queue,
                        rx_pkts[nb_rx]->pkt_len += (uint32_t)(len[i]);
                        rx_pkts[nb_rx]->data_len += (uint16_t)(len[i]);
 
-                       if (prev)
-                               prev->next = rxm;
-
+                       prev->next = rxm;
                        prev = rxm;
                        seg_res -= 1;
                }
@@ -1927,8 +1921,7 @@ virtio_recv_mergeable_pkts_packed(void *rx_queue,
                } else {
                        PMD_RX_LOG(ERR,
                                        "No enough segments for packet.");
-                       if (prev)
-                               virtio_discard_rxbuf(vq, prev);
+                       virtio_discard_rxbuf(vq, prev);
                        rxvq->stats.errors++;
                        break;
                }
-- 
2.21.0