Hi Wei, <snip>
> > Subject: [PATCH v2] app/testpmd: remove port stop check for macsec > > > > There is no need to do such a check when set macsec for ixgbe, > > reconfig_device_queueand is also useless. If we do not delete this Typo: space missing before "and" in previous line. > > unnessary code, users have to sotp port before enable or disable Typo: "sotp" should be "stop" > > macsec, then restart this port after make configuration. All these Typo: "these" should be "this" > > process is useless. As this cmdline is a private API which is only used by > > ixgbe > NIC, so remove it. > > > > Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Wei Zhao <wei.zh...@intel.com> Otherwise Acked-by: Bernard Iremonger <bernard.iremon...@intel.com>