> -----Original Message----- > From: Richardson, Bruce > Sent: Friday, June 7, 2019 3:01 PM > To: Stephen Hemminger <step...@networkplumber.org> > Cc: Varghese, Vipin <vipin.vargh...@intel.com>; olivier.m...@6wind.com; > Pattan, Reshma <reshma.pat...@intel.com>; Wiles, Keith > <keith.wi...@intel.com>; dev@dpdk.org; Padubidri, Sanjay A > <sanjay.padubi...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue callabck > > On Thu, Jun 06, 2019 at 12:49:27PM -0700, Stephen Hemminger wrote: > > On Fri, 7 Jun 2019 00:03:54 +0530 > > Vipin Varghese <vipin.vargh...@intel.com> wrote: > > > > > Add callback event handler for enqueue dequeue operation on ring. > > > The pre-enqueue and post-dequeue operation on ring is selected to > > > invoke user callback handler. > > > > > > Signed-off-by: Vipin Varghese <vipin.vargh...@intel.com> > > > --- > > > > NAK > > What is the use case for this? Rings are one of the most used elements > > of DPDK and anything like this will have performance impact. > > > > And as DPDK goes to more of distribution model, all features have to > > be enabled. > > > To add callback handlers to a ring, I'd suggest wrapping the ring as an ethdev > using the ring pmd, and then using the ethdev callbacks.
Thanks Bruce, I will check the same and get back. > > /Bruce
