2015-12-08 01:54, Betts, Ian: > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, December 8, 2015 1:36 AM > To: Betts, Ian > Cc: dev at dpdk.org; stephen at networkplumber.org; Richardson, Bruce > Subject: Re: [PATCH v9 3/4] examples: add l3fwd-thread example in > performance-thread > > > +M: Ian Betts <ian.betts at intel.com> > > +M: John McNamara <john.mcnamara at intel.com> > > +F: doc/guides/sample_app_ug/performance_thread.rst > > > Why doing 2 sections? > > John is already the doc maintainer. You don't need to add him here. > > I just copy most of the other examples which also do this. > I also thought it was odd.
No, John is really the co-maintainer of some examples. Please talk with him, you are in the same company. > I will remove him. > > > --- a/examples/Makefile > > +++ b/examples/Makefile > > @@ -77,5 +77,9 @@ DIRS-y += vmdq > > DIRS-y += vmdq_dcb > > DIRS-$(CONFIG_RTE_LIBRTE_POWER) += vm_power_manager > > DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += l2fwd-crypto > > - > > +ifneq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),) > > +ifneq ($(CONFIG_RTE_ARCH_X86_64),) > > +DIRS-y += performance-thread > > +endif > > +endif > > > Matter of taste, I would prefer DIRS-$(CONFIG_RTE_ARCH_X86_64) > > I need to combine CONFIG_RTE_EXEC_ENV_LINUXAPP ( the two clauses ) +ifneq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),) +DIRS-$(CONFIG_RTE_ARCH_X86_64) += performance-thread +endif It highlights the main dependency of this code: x86