Hi, Ferruh I will fix this in next version. Thanks
-----Original Message----- From: Yigit, Ferruh Sent: Tuesday, June 18, 2019 8:40 PM To: Pei, Andy <[email protected]>; [email protected] Cc: Xu, Rosen <[email protected]> Subject: Re: [dpdk-dev] [PATCH v2 4/4] net/ipn3ke: implementation of statistics On 6/18/2019 12:59 PM, Ferruh Yigit wrote: > On 6/11/2019 10:48 AM, Andy Pei wrote: >> This patch implemente statistics read and reset function for ipn3ke. >> >> Fixes: 70d6b7f550f4 ("net/ipn3ke: add representor") >> Cc: [email protected] >> >> Signed-off-by: Andy Pei <[email protected]> > > <...> > >> +#define IPN3KE_RPST_TXQ_PRIO_XSTATS_CNT >> (sizeof(ipn3ke_rpst_txq_prio_strings) \ >> + / sizeof(ipn3ke_rpst_txq_prio_strings[0])) >> + >> +static uint32_t >> +ipn3ke_rpst_xstats_calc_num(void) >> +{ >> + return IPN3KE_RPST_ETH_XSTATS_CNT >> + + IPN3KE_RPST_HW_PORT_XSTATS_CNT >> + + (IPN3KE_RPST_RXQ_PRIO_XSTATS_CNT >> + * IPN3KE_RPST_PRIO_XSTATS_CNT) >> + + (IPN3KE_RPST_TXQ_PRIO_XSTATS_CNT >> + * IPN3KE_RPST_PRIO_XSTATS_CNT); >> +} >> + >> +#if 0 > > Please don't add "#if 0" to the code, if required you can delete the > code, same is valid for below one too. > Also getting following build error in patch by patch build [1], please remind that each individual patch should build successfully. [1] .../dpdk/drivers/net/ipn3ke/ipn3ke_ethdev.c: In function ‘ipn3ke_hw_init’: .../dpdk/drivers/net/ipn3ke/ipn3ke_ethdev.c:248:4: error: implicit declaration of function ‘ipn3ke_xmac_tx_clr_stcs’; did you mean ‘ipn3ke_xmac_tx_clr_25G_stcs’? [-Werror=implicit-function-declaration] 248 | ipn3ke_xmac_tx_clr_stcs(hw, i, 1); | ^~~~~~~~~~~~~~~~~~~~~~~ | ipn3ke_xmac_tx_clr_25G_stcs
