On Wed, Jun 19, 2019 at 9:24 PM Stephen Hemminger < step...@networkplumber.org> wrote:
> C language does not really treat enum's as first class symbols. > The values in an enum live in a global namespace. That means if > DPDK defines "RUNNING" it can't be used by another enum in an > application using DPDK. > > To solve this add a prefix "RTE_LCORE_" to the enum values, and > make them grammatically consistent. > > Also, simplify the inline thread_is_running() which is copied > in softnic and ip_pipeline. > > Signed-off-by: Stephen Hemminger <step...@networkplumber.org> > --- > v4 - rebase (after lcore changes),fix FreeBSD typo > > Did an extra pass, you missed the windows eal and the api descriptions: https://github.com/david-marchand/dpdk/commit/0084114455a82f90b783bdf1659a4af6f76c89f2 My only objection to this patch is that we are breaking a public API by removing those enums. We need to maintain those and send a deprecation notice for their future removal. -- David Marchand
