Thanks for your comments. I'll add it in v4. > -----Original Message----- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Thursday, June 20, 2019 9:34 PM > To: Yang, Qiming <qiming.y...@intel.com> > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API > > Qiming Yang <qiming.y...@intel.com> writes: > > > This patch adds ice_flow_create, ice_flow_destroy, ice_flow_flush and > > ice_flow_validate support, these are used to handle all the generic > > filters. > > > > Signed-off-by: Qiming Yang <qiming.y...@intel.com> > > --- > > drivers/net/ice/Makefile | 1 + > > drivers/net/ice/ice_ethdev.c | 44 +++ > > drivers/net/ice/ice_ethdev.h | 5 + > > drivers/net/ice/ice_generic_flow.c | 682 > > +++++++++++++++++++++++++++++++++++++ > > drivers/net/ice/ice_generic_flow.h | 654 > +++++++++++++++++++++++++++++++++++ > > drivers/net/ice/meson.build | 1 + > > 6 files changed, 1387 insertions(+) > > create mode 100644 drivers/net/ice/ice_generic_flow.c > > create mode 100644 drivers/net/ice/ice_generic_flow.h > > > > diff --git a/drivers/net/ice/Makefile b/drivers/net/ice/Makefile index > > b10d826..32abeb6 100644 > > --- a/drivers/net/ice/Makefile > > +++ b/drivers/net/ice/Makefile > > @@ -79,5 +79,6 @@ endif > > ifeq ($(CC_AVX2_SUPPORT), 1) > > SRCS-$(CONFIG_RTE_LIBRTE_ICE_PMD) += ice_rxtx_vec_avx2.c endif > > +SRCS-$(CONFIG_RTE_LIBRTE_ICE_PMD) += ice_generic_flow.c > > [...]
> > +#endif > > diff --git a/drivers/net/ice/meson.build b/drivers/net/ice/meson.build > > index 8697676..18180b9 100644 > > --- a/drivers/net/ice/meson.build > > +++ b/drivers/net/ice/meson.build > > @@ -8,6 +8,7 @@ sources = files( > > 'ice_ethdev.c', > > 'ice_rxtx.c', > > 'ice_switch_filter.c' > > Missing a comma here. > > > + 'ice_generic_flow.c' > > ) > > > > deps += ['hash']
