Hi Akhil, I'll fix the issues and send a revised patch.
Thanks, Anoob > -----Original Message----- > From: dev <dev-boun...@dpdk.org> On Behalf Of Akhil Goyal > Sent: Friday, June 21, 2019 6:40 PM > To: Anoob Joseph <ano...@marvell.com>; Declan Doherty > <declan.dohe...@intel.com>; Fiona Trahe <fiona.tr...@intel.com>; Pablo > de Lara <pablo.de.lara.gua...@intel.com>; dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran <jer...@marvell.com>; Narayana Prasad Raju > Athreya <pathr...@marvell.com> > Subject: [EXT] Re: [dpdk-dev] [PATCH] cryptodev: add ff_disable field in > cryptodev config > > External Email > > ---------------------------------------------------------------------- > Hi Anoob, > > > > > Adding a new field, ff_disable, to allow applications to control the > > features enabled on the crypto device. This would allow for efficient > > usage of HW/SW offloads by disabling the features not required by the > > application. > > > > Signed-off-by: Anoob Joseph <ano...@marvell.com> > > I see a compilation issue with this change. > /home/akhil/up/dpdk-next- > crypto/examples/fips_validation/fips_dev_self_test.c: In function > 'fips_dev_auto_test_init': > /home/akhil/up/dpdk-next- > crypto/examples/fips_validation/fips_dev_self_test.c:1560:9: error: missing > initializer for field 'ff_disable' of 'struct rte_cryptodev_config' [- > Werror=missing-field-initializers] > struct rte_cryptodev_config conf = {rte_cryptodev_socket_id(dev_id), 1}; > ^~~~~~~~~~~~~~~~~~~~ > In file included from /home/akhil/up/dpdk-next- > crypto/examples/fips_validation/fips_dev_self_test.c:5:0: > /home/akhil/up/dpdk-next-crypto/arm64-dpaa-linuxapp- > gcc/include/rte_cryptodev.h:615:11: note: 'ff_disable' declared here > uint64_t ff_disable; > ^~~~~~~~~~ > > Please add a patch for all applications which use struct rte_cryptodev_config > and set the default values of its parameters. > > > --- > > doc/guides/rel_notes/deprecation.rst | 14 -------------- > > doc/guides/rel_notes/release_19_08.rst | 11 ++++++++++- > > lib/librte_cryptodev/Makefile | 2 +- > > lib/librte_cryptodev/meson.build | 2 +- > > lib/librte_cryptodev/rte_cryptodev.h | 7 +++++++ > > 5 files changed, 19 insertions(+), 17 deletions(-) > >