Hi Reshma, I am still seeing build issue when rebasing to this : ie. checking uint32_t is negative in rte_telemetry.c:558 Thanks Nic
-----Original Message----- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon Sent: Monday, June 24, 2019 7:54 AM To: Pattan, Reshma <reshma.pat...@intel.com> Cc: dev@dpdk.org; Laatz, Kevin <kevin.la...@intel.com> Subject: Re: [dpdk-dev] [PATCH v2] lib/telemetry: add support to fetch global metrics 18/06/2019 15:49, Reshma Pattan: > telemetry has support for fetching port based stats from metrics > library. > > Metrics library also has global stats which are not fetched by > telemetry, so extend telemetry to fetch the global metrics. > > Signed-off-by: Reshma Pattan <reshma.pat...@intel.com> > Acked-by: Kevin Laatz <kevin.la...@intel.com> > --- > v2: fix GCC compilation issues. > rebase with latest release notes. Applied, thanks