On Wed, Jun 26, 2019 at 11:03 PM Thomas Monjalon <tho...@monjalon.net> wrote:
> 07/06/2019 10:32, David Marchand: > > On Thu, Jun 6, 2019 at 12:03 PM Ilya Maximets <i.maxim...@samsung.com> > > wrote: > > > > > According to API, 'rte_dev_probe()' and 'rte_dev_remove()' must > > > return 0 or negative error code. Bus code returns positive values > > > if device wasn't recognized by any driver, so the result of > > > 'bus->plug/unplug()' must be converted. 'local_dev_probe()' and > > > 'local_dev_remove()' also has their internal API, so the conversion > > > should be done there. > > > > > > Positive on remove means that device not found by driver. > > > > > > > For backports, it is safer to add the check on > 0. > > The patch looks good to me. > > > > Reviewed-by: David Marchand <david.march...@redhat.com> > > I did not get your comment. Is it OK to get this v2? > What do you mean about backports? > > Yes this v2 is ok. I wanted to dissociate from my other comments which would not be part of the fix for stable. -- David Marchand