> -----Original Message-----
> From: dev [mailto:[email protected]] On Behalf Of Harman Kalra
> Sent: Friday, March 1, 2019 10:08 AM
> To: Horton, Remy <[email protected]>; Burakov, Anatoly
> <[email protected]>; Kovacevic, Marko
> <[email protected]>; Mcnamara, John
> <[email protected]>
> Cc: [email protected]; [email protected]; Harman Kalra <[email protected]>
> Subject: [dpdk-dev] [PATCH v2 1/2] metrics: new API to deinitialise metrics
> library
>
> Once the library usage is over, it must be deinitialized which will free the
> shared memory reserved during initialization.
>
> Fixes: observed an issue while running 'metrics_autotest'
> continuously without quiting. For the first run 'metrics_autotest'
> passes all test cases but second run onwards first test case fails because
> metrics library is already initialized during first run.
> Cc: [email protected]
>
> Signed-off-by: Harman Kalra <[email protected]>
> ---
> v2:
> * Adding [email protected] into cc as this patch falls between bug fix and
> new feature.
>
> doc/guides/prog_guide/metrics_lib.rst | 14 ++++++++++++++
> lib/librte_metrics/rte_metrics.c | 20 ++++++++++++++++++++
> lib/librte_metrics/rte_metrics.h | 17 +++++++++++++++++
> lib/librte_metrics/rte_metrics_version.map | 6 ++++++
> 4 files changed, 57 insertions(+)
>
> diff --git a/doc/guides/prog_guide/metrics_lib.rst
> b/doc/guides/prog_guide/metrics_lib.rst
> index e68e4e743..08e107df3 100644
> --- a/doc/guides/prog_guide/metrics_lib.rst
> +++ b/doc/guides/prog_guide/metrics_lib.rst
> @@ -154,6 +154,20 @@ print out all metrics for a given port:
> }
>
>
> +Deinitialising the library
> +------------------------
1)
The underline should be same length as heading. Below is the error from "make
doc-guides-html"
sphinx processing guides-html...
metrics_lib.rst:158: WARNING: Title underline too short.
Deinitialising the library
------------------------
metrics_lib.rst:158: WARNING: Title underline too short.
2) Need to fix below
./devtools/check-git-log.sh
Wrong tag:
Fixes: observed an issue while running 'metrics_autotest'
Wrong 'Fixes' reference:
Fixes: observed an issue while running 'metrics_autotest'
If you want to add Fixes line it should be of below form
Fixes: <commitd> ("commit heading")
Ex: Fixes: d7a0da3c0043 ("mempool/octeontx2: add fast path mempool ops")
Otherwise,
Tested-by : Reshma Pattan <[email protected]>
Reviewed-by: Reshma Pattan <[email protected]>
Acked-by: Reshma Pattan <[email protected]>
Please keep these tags for next versions, otherwise it can easily miss from
being applied.
Thanks,
Reshma
