Hi Shally,


-----Original Message-----
From: Tomasz Jozwiak <tjozwia...@gmail.com>
Sent: Wednesday, June 26, 2019 11:05 PM
To: Shally Verma <shal...@marvell.com>; dev@dpdk.org;
fiona.tr...@intel.com; arturx.tryb...@intel.com
Subject: Re: [EXT] [PATCH v3 2/7] app/test-compress-perf: add ptest
command line option

Hi Shally,


-----Original Message-----
From: Tomasz Jozwiak <tjozwia...@gmail.com>
Sent: Wednesday, June 26, 2019 10:00 PM
To: dev@dpdk.org; fiona.tr...@intel.com; tjozwia...@gmail.com;
Shally
Verma <shal...@marvell.com>; arturx.tryb...@intel.com
Subject: [EXT] [PATCH v3 2/7] app/test-compress-perf: add ptest
command line option

External Email

---------------------------------------------------------------------
-
From: Tomasz Jozwiak <tomaszx.jozw...@intel.com>

This patch adds --ptest option to make possible a choose of test case
from command line.

Signed-off-by: Tomasz Jozwiak <tomaszx.jozw...@intel.com>
---
   app/test-compress-perf/comp_perf_options_parse.c | 36
++++++++++++++++++++++++
   1 file changed, 36 insertions(+)

diff --git a/app/test-compress-perf/comp_perf_options_parse.c
b/app/test- compress-perf/comp_perf_options_parse.c
index bc4b98a..07672b2 100644
--- a/app/test-compress-perf/comp_perf_options_parse.c
+++ b/app/test-compress-perf/comp_perf_options_parse.c
@@ -15,6 +15,7 @@

   #include "comp_perf_options.h"

+#define CPERF_PTEST_TYPE       ("ptest")
   #define CPERF_DRIVER_NAME    ("driver-name")
   #define CPERF_TEST_FILE              ("input-file")
   #define CPERF_SEG_SIZE               ("seg-sz")
@@ -37,6 +38,7 @@ static void
   usage(char *progname)
   {
        printf("%s [EAL options] --\n"
+               " --ptest benchmark / verify :"
                " --driver-name NAME: compress driver to use\n"
                " --input-file NAME: file to compress and decompress\n"
                " --extended-input-sz N: extend file data up to this size
(default: no extension)\n"
@@ -76,6 +78,37 @@ get_str_key_id_mapping(struct name_id_map
*map,
unsigned int map_len,  }

   static int
+parse_cperf_test_type(struct comp_test_data *test_data, const char
+*arg) {
+       struct name_id_map cperftest_namemap[] = {
+               {
+
        cperf_test_type_strs[CPERF_TEST_TYPE_BENCHMARK],
+                       CPERF_TEST_TYPE_BENCHMARK
+               },
+               {
+                       cperf_test_type_strs[CPERF_TEST_TYPE_VERIFY],
+                       CPERF_TEST_TYPE_VERIFY
+               },
+               {
+                       cperf_test_type_strs[CPERF_TEST_TYPE_PMDCC],
+                       CPERF_TEST_TYPE_PMDCC
What is PMDCC here? What kind of test type?
[Tomek] This's for 'pmd_cyclecount_test'. Actually compression_perf tool

doesn't support that test, but we added a sort of 'template' for that, cause
there's a plan to add

this test in the future.
Isn’t it better we add this .. when we actually add feature?

[Tomek] True , I'll remove this in V4.


Thx, Tomek




Reply via email to