Re: [dpdk-dev] [RFC 1/5] eal: add the APIs to wait until equal

[Gavin Hu (Arm Technology China)]

Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Monday, July 1, 2019 3:43 PM
> To: Gavin Hu (Arm Technology China) <gavin...@arm.com>
> Cc: Stephen Hemminger <step...@networkplumber.org>; dev@dpdk.org;
> jer...@marvell.com; hemant.agra...@nxp.com;
> bruce.richard...@intel.com; chao...@linux.vnet.ibm.com; Honnappa
> Nagarahalli <honnappa.nagaraha...@arm.com>; nd <n...@arm.com>;
> gaetan.ri...@6wind.com
> Subject: Re: [dpdk-dev] [RFC 1/5] eal: add the APIs to wait until equal
> 
> 01/07/2019 09:16, Gavin Hu (Arm Technology China):
> > From: Stephen Hemminger <step...@networkplumber.org>
> > > Gavin Hu <gavin...@arm.com> wrote:
> > >
> > > > +#ifdef RTE_USE_WFE
> > > > +#define rte_wait_until_equal_relaxed(addr, expected) do {\
> [...]
> > > That is a hot mess.
> > > Macro's are harder to maintain and offer no benefit over inline functions.
> >
> > During our internal review, I ever used C11 _Generic to generalize the API
> to take different types of arguments.
> 
> Gavin, the question is about macros versus functions.
> Please, could you convert it into an inline function?
Sure, I will do it in next version.