> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Wednesday, July 3, 2019 2:35 PM
> To: Xing, Beilei <beilei.x...@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zh...@intel.com>; sta...@dpdk.org
> Subject: [PATCH] net/i40e: fix unexpected skip fdir setup
> 
> In i40e_flow_flush_fdir_filter, i40e_fdir_teardown is called, so
> i40e_fdir_setup is required to be called before create a new fdir flow.
> 
> Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Qi Zhang <qi.z.zh...@intel.com>
> ---
>  drivers/net/i40e/i40e_flow.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index
> d62b32f17..48a6782a8 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -3175,8 +3175,8 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev
> *dev,
> 
>       cons_filter_type = RTE_ETH_FILTER_FDIR;
> 
> -     if (dev->data->dev_conf.fdir_conf.mode !=
> -         RTE_FDIR_MODE_PERFECT) {
> +     if (dev->data->dev_conf.fdir_conf.mode !=
> RTE_FDIR_MODE_PERFECT ||
> +             pf->fdir.fdir_vsi == NULL) {
>               /* Enable fdir when fdir flow is added at first time. */
>               ret = i40e_fdir_setup(pf);
>               if (ret != I40E_SUCCESS) {
> --
> 2.13.6

Acked-by: Beilei Xing <beilei.x...@intel.com>

Reply via email to