Hi, On Thu, Jul 04, 2019 at 06:29:25PM +0200, Thomas Monjalon wrote: > 15/03/2019 16:27, Harman Kalra: > > Since pdump uses SW rings to manage packets hence > > pdump should use SW ring mempool for managing its > > own copy of packets. > > I'm not sure to understand the reasoning. > Reshma, Olivier, Andrew, any opinion? > > Let's take a decision for this very old patch.
>From what I understand, many mempools of packets are created, to store the copy of dumped packets. I suppose that it may not be possible to create as many mempools by using the "best" mbuf pool (from rte_mbuf_best_mempool_ops()). Using a "ring_mp_mc" as mempool ops should always be possible. I think it would be safer to use "ring_mp_mc" instead of CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS, because the latter could be overriden on a specific platform. Olivier
