On Tue, Jul 02, 2019 at 03:12:41PM -0700, Stephen Hemminger wrote: > Now that there is a version of ether_aton in rte_ether, it can > be used by the cmdline ethernet address parser. > > Note: ether_aton_r can not be used in cmdline because > the old code would accept either bytes XX:XX:XX:XX:XX:XX > or words XXXX:XXXX:XXXX and we need to keep compatiablity. > > Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
Acked-by: Olivier Matz <olivier.m...@6wind.com> Thanks! BTW, I noticed that it also fixes a more serious bug: the previous commandline parser was using a static buffer, making it thread-unsafe. I didn't see any places that could have been impacted.